[prone] Add `TimeRulesRecipes` #35861

Pankraz76 · 2025-11-20T13:32:52Z

Congratulations on the recent major release — a lot of work has clearly gone into it.
I'm sure Spring Boot will continue to succeed as well.

I’d kindly like to suggest considering Error Prone integration featuring the TimeRules findings:

As discussed in:

Add rewrite support for errorprone.refasterrules #35270

Changes have been made to spring-context/src/main/java/org/springframework/scheduling/support/CronTrigger.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-context/src/main/java/org/springframework/format/datetime/standard/DateTimeConverters.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-context/src/test/java/org/springframework/scheduling/concurrent/DefaultManagedTaskSchedulerTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfMinutesRecipe
Changes have been made to spring-test/src/main/java/org/springframework/test/http/HttpHeadersAssert.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/servlet/result/HeaderResultMatchersTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/servlet/client/RestTestClientTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-test/src/test/java/org/springframework/test/web/support/HeaderAssertionTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/main/java/org/springframework/web/server/session/InMemoryWebSessionStore.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcClockRecipe
Changes have been made to spring-web/src/main/java/org/springframework/http/HttpHeaders.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$InstantAtZoneRecipe
Changes have been made to spring-web/src/test/java/org/springframework/web/server/i18n/FixedLocaleContextResolverTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-web/src/test/java/org/springframework/http/client/reactive/ClientHttpConnectorTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Changes have been made to spring-webflux/src/test/java/org/springframework/web/reactive/function/server/DefaultRenderingResponseTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$DurationOfMillisRecipe
Changes have been made to spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessorMockTests.java by:
    tech.picnic.errorprone.refasterrules.TimeRulesRecipes
        tech.picnic.errorprone.refasterrules.TimeRulesRecipes$UtcConstantRecipe
Please review and commit the results.
Estimate time saved: 1h 10m

Pankraz76 · 2025-11-20T13:36:16Z

rewrite.yml

+  - tech.picnic.errorprone.refasterrules.StreamRulesRecipes
+  # TBD
+  # - org.openrewrite.java.migrate.Java8toJava11 # https://github.com/google/error-prone/pull/5328
+  # - org.openrewrite.java.migrate.UpgradeToJava17 # https://github.com/checkstyle/checkstyle/pull/17730


Since Checkstyle is already used within Spring, it’s effectively part of the project transitively.

Integrating these rules directly could improve a lot of code and allow best practices to be applied effortlessly and consistently.

Pankraz76 · 2025-11-20T13:37:59Z

.github/actions/build/action.yml

        version=$(sed -n 's/version=\(.*\)/\1/p' gradle.properties)
        echo "Version is $version"
        echo "version=$version" >> $GITHUB_OUTPUT
+    - name: SanityCheck


I’m not sure if this is the right place to check. Having this last in place should allow most of the other steps to work, but it still ends up failing with a corrupt version.

mdeinum · 2025-11-20T19:33:38Z

...src/main/java/org/springframework/context/aot/ReflectiveProcessorAotContributionBuilder.java

 import java.util.Set;
-import java.util.stream.StreamSupport;

+import com.google.common.collect.Streams;


Apart from the commons-logging and micrometer-api dependencies there are no 3rd party dependencies in Spring. I doubt adding a dependency on Google Guava is going to happen anytime soon.

yes this seems questionable. Thanks for the hint.

mdeinum · 2025-11-20T19:35:00Z

spring-web/src/main/java/org/springframework/http/server/DefaultPathContainer.java


 		List<Element> subList = elements.subList(fromIndex, toIndex);
-		String path = subList.stream().map(Element::value).collect(Collectors.joining(""));
+		String path = subList.stream().map(Element::value).collect(joining());


I believe there is a no static import rule.

yes it seems to be the bulky and verbose checkstyle style and not the slim google approach.

https://error-prone.picnic.tech/bugpatterns/NonStaticImport/

https://error-prone.picnic.tech/bugpatterns/StaticImport/

[prone] remove failing tech.picnic.error-prone-support diffplug/spotless#2766

mdeinum

Looking at existing rules and deliberate care in dependencies I would expect some changes. Which would mean that the rewrite rules aren't applicable.

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Pankraz76 · 2025-11-21T10:16:52Z

Looking at existing rules and deliberate care in dependencies I would expect some changes. Which would mean that the rewrite rules aren't applicable.

Thank you for the kind feedback.

I’ve reworked the scope to focus on the TimeRules. Hopefully this is something easier to consider.

the rewrite rules aren't applicable.

I think it’s difficult to judge something universally or generically; each scope has its own individual context.

This is the first project that passed the included GradleBestPractices checks without any findings.
That suggests the codebase is already very up-to-date regarding this scope — well done.

Considering the Java8toJava11 migration, as explored in

the code compiles on Java 21+ while still largely using Java 8–era and Java 17–era constructs.
That’s something to consider — similar to how Checkstyle, Google Error Prone, and Spotless have already done clean up the entire codebase in a glance.

spring-test/src/main/java/org/springframework/test/http/HttpHeadersAssert.java

spring-test/src/test/java/org/springframework/test/web/servlet/client/RestTestClientTests.java

spring-web/src/test/java/org/springframework/http/HttpHeadersTests.java

Pankraz76 · 2025-11-21T10:18:49Z

...g-web/src/test/java/org/springframework/web/server/i18n/FixedLocaleContextResolverTests.java

 	@Test
 	void resolveCustomizedAndTimeZoneLocale() {
-		TimeZone timeZone = TimeZone.getTimeZone(ZoneId.of("UTC"));
+		TimeZone timeZone = TimeZone.getTimeZone(ZoneOffset.UTC);


this seems a good thing to consider, being straight up instead of "error prone".

What do you mean?

sorry i meant this is a good thing and seems easy consider suggest, as it avoids error prone (random) string.

...rg/springframework/web/servlet/mvc/method/annotation/HttpEntityMethodProcessorMockTests.java

spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 20, 2025

Pankraz76 commented Nov 20, 2025

View reviewed changes

mdeinum reviewed Nov 20, 2025

View reviewed changes

Pankraz76 changed the title ~~[prone] Add StreamRulesRecipes~~ [prone] Add TimeRulesRecipes Nov 21, 2025

[prone] Add TimeRulesRecipes

def2188

Signed-off-by: Vincent Potucek <vpotucek@me.com>

Pankraz76 force-pushed the fix-StreamRulesRecipes branch from a8e5b97 to def2188 Compare November 21, 2025 10:03

Pankraz76 commented Nov 21, 2025

View reviewed changes

Pankraz76 requested a review from mdeinum November 21, 2025 13:28

Pankraz76 mentioned this pull request Nov 22, 2025

[prone] remove failing tech.picnic.error-prone-support diffplug/spotless#2766

Merged

3 tasks

[prone] Add TimeRulesRecipes #35861

Are you sure you want to change the base?

[prone] Add TimeRulesRecipes #35861

Conversation

Pankraz76 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pankraz76 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

mdeinum Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

mdeinum Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mdeinum left a comment

Choose a reason for hiding this comment

Uh oh!

Pankraz76 commented Nov 21, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Pankraz76 Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rickie Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Pankraz76 Nov 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[prone] Add `TimeRulesRecipes` #35861

[prone] Add `TimeRulesRecipes` #35861

Pankraz76 commented Nov 20, 2025 •

edited

Loading

Pankraz76 Nov 21, 2025 •

edited

Loading

Pankraz76 Nov 21, 2025 •

edited

Loading