[ECMAScript6BestPractices] fix common-serve.js
#2773
Conversation
Signed-off-by: Vincent Potucek <vpotucek@me.com>
| } | ||
|
|
||
| function getInstanceId() { | ||
| const args = process.argv.slice(2); |
There was a problem hiding this comment.
considering this unused coupling as inlineable and cast away like Wilson. also random magic number.
| let instanceId; | ||
|
|
||
| args.forEach(arg => { | ||
| process.argv.slice(2).forEach(arg => { |
There was a problem hiding this comment.
more cohesion less coupling. now the 2 and 1 is kind of related making it a little less magic.
| } | ||
| }); | ||
| }); | ||
| const shutdown = shutdownServer(listener, { |
There was a problem hiding this comment.
considering this unused coupling as inlineable and cast away like Wilson.
| await shutdownServer(listener, { | ||
| forceExit: false, // let the event loop clear | ||
| finally: () => debugLog("graceful shutdown finished."), | ||
| })(); |
There was a problem hiding this comment.
This is for JS pros—creating a function inline and directly. In my opinion, this is logically equivalent, but I’m not a pro.
| @@ -1,26 +1,26 @@ | |||
| import shutdownServer from 'http-graceful-shutdown'; | |||
There was a problem hiding this comment.
first things first, also workaround-fixing the comment bug in rewrite.
| import fs from 'fs'; | ||
|
|
||
| // | ||
| // this file will be glued to the top of the specific xy-serve.js file |
There was a problem hiding this comment.
could undo but making this info a little more bold as this is quite unique imho.
1 participant
enabler for:
ECMAScript6BestPractices#2768related to:
ECMAScript6BestPracticesendless comment copy bug. openrewrite/rewrite#6330