feat: read scalafmt version from scalafmt config if not provided#2922
Merged
nedtwigg merged 3 commits intoMay 14, 2026
Merged
Conversation
Contributor
Author
|
@nedtwigg could you please check this PR out? |
…sion-from-scalafmt-config # Conflicts: # CHANGES.md # plugin-gradle/CHANGES.md # plugin-maven/CHANGES.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Scalafmt config files already carry a version field (e.g. version = 3.8.1) and it is mandatory. Requiring users to also declare the version in their Spotless plugin config is redundant and a source of inconsistency.
Change
When no explicit scalafmt version is configured in the plugin, Spotless now reads it from the scalafmt config file. Only if the config file is absent or has no version field (which is invalid) it falls back to the built-in default (3.8.1). If a version is explicitly set in the plugin config, it takes precedence and the existing mismatch check still applies (to keep it all backward compatible).
Scope
The resolution logic lives in lib (ScalaFmtStep), so both the Maven and Gradle plugins benefit automatically. Both plugins were updated to pass null when no version is explicitly configured, and some tests were added for both.