Skip to content

fix: fix path separator in windows #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 2 commits into from
Apr 20, 2026
Merged

fix: fix path separator in windows #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c46661b
fix: fix path separator in windows
ycexiao Apr 19, 2026
bcc5d2a
chore: add news
ycexiao Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions news/fix-ci.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
**Added:**

* No news added: Fix path separator mismatch for different platforms in the tests.

**Changed:**

* <news item>

**Deprecated:**

* <news item>

**Removed:**

* <news item>

**Fixed:**

* <news item>

**Security:**

* <news item>
5 changes: 3 additions & 2 deletions tests/test_runmacro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import re
from pathlib import Path

import numpy
Expand Down Expand Up @@ -186,7 +187,7 @@ def test_command_processor(
(
'load structure foo from "/nonexistent/path.cif"',
FileNotFoundError,
"structure /nonexistent/path.cif not found. "
f"structure {Path('/nonexistent/path.cif')} not found. "
"Please ensure the path is correct and the file exists.",
),
(
Expand All @@ -207,5 +208,5 @@ def test_command_processor(
)
def test_load_command_processor_bad(command_string, expected_exception, match):
parser = MacroParser()
with pytest.raises(expected_exception, match=match):
with pytest.raises(expected_exception, match=re.escape(match)):
parser.parse(command_string)
Loading