Skip to content

feat: support single line comment in the macro file#19

Merged
sbillinge merged 2 commits intodiffpy:mainfrom
ycexiao:single-line-comment
Apr 20, 2026
Merged

feat: support single line comment in the macro file#19
sbillinge merged 2 commits intodiffpy:mainfrom
ycexiao:single-line-comment

Conversation

@ycexiao
Copy link
Copy Markdown
Contributor

@ycexiao ycexiao commented Apr 20, 2026

What problem does this PR address?

Closes #18

Support single line comment like

# This is a comment
<macro-commands>

in the macro file.

What should the reviewer(s) do?

@ycexiao ycexiao marked this pull request as ready for review April 20, 2026 18:41
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (0a48d18) to head (c9cb44b).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   92.94%   92.94%           
=======================================
  Files           4        4           
  Lines         156      156           
=======================================
  Hits          145      145           
  Misses         11       11           
Files with missing lines Coverage Δ
tests/helper.py 96.87% <ø> (ø)
tests/test_runmacro.py 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycexiao
Copy link
Copy Markdown
Contributor Author

ycexiao commented Apr 20, 2026

@sbillinge, it's ready for review.

@sbillinge sbillinge merged commit 85d1242 into diffpy:main Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support using # to add comment in the macro file

2 participants