skpkg: complete migration

[dabeycorn]

No description provided.

[dabeycorn]

@zmx27 @sbillinge ready for review

[sbillinge]

@dabeycorn I don't review this, but you verify that all the steps of the migration have been completed. What does git status return, for example.

[dabeycorn]

All steps seem to be completed and git status returns no unstaged files. Should be good to merge.

[sbillinge]

All steps seem to be completed and git status returns no unstaged files. Should be good to merge.

no unstaged files, good. What about modified and deleted files?

[dabeycorn]

There are none listed

[zmx27]

Just as a piece of advice, but in the future, it's good practice to simply post a copy/paste of the result of running git status, pre-commit, pytest, etc to avoid back and forths like this

[dabeycorn]

Here are the outputs from git status, pre-commit, and pytest:

---

---

[sbillinge]

Thanks @dabeycorn this is much better. It looks good. Could you report the pre-commit on --all-files though? Seeing a bunch of skips is not so informative, right? Please treat these not as "tasks I have been asked to do so I am doing them" but rather, "I want to communicate clearly and effectively with the dev team, what is the best way I can do that?"

[dabeycorn]

Sorry, I've updated the screenshots in the message above. I'll try to put more thought into my future PRs.

[sbillinge]

super, thanks @dabeycorn

@zmx27 I think we need to start generating some release issues for each of the packages. We can have the same people who did the migration as leading the release, so either organize that they do the release issues, or that you make the issue but have them do the checklists.

Nearly there!