Skip to content

build: remove gsl as the dependency in the build#27

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:dependency-build-fix
May 12, 2026
Merged

build: remove gsl as the dependency in the build#27
sbillinge merged 4 commits into
diffpy:mainfrom
stevenhua0320:dependency-build-fix

Conversation

@stevenhua0320
Copy link
Copy Markdown
Contributor

@stevenhua0320 stevenhua0320 commented May 11, 2026

@sbillinge ready to review. This is specific for the build on conda-forge as gsl is not needed directly by this package. When we list this as a requirement in conda, it could not understand why we need this and the pip check would fail.
In addition, we need the namespace extension to avoid the conflict as seen in the conda-forge build failure.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.63%. Comparing base (b5a3371) to head (4c0ae3a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   81.63%   81.63%           
=======================================
  Files           3        3           
  Lines          49       49           
=======================================
  Hits           40       40           
  Misses          9        9           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment

Comment thread src/diffpy/__init__.py Outdated
"""


from pkgutil import extend_path
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to avoid this. We don't do it for any of our other packages that all build correctly, so I think this is not the right fix. Let's at least revert this and merge the gsl fix.

@sbillinge sbillinge merged commit cd004d4 into diffpy:main May 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants