Migrate to pre-commit ci #112
Conversation
| autoupdate_branch: 'pre-commit-autoupdate' | ||
| autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' | ||
| autoupdate_schedule: monthly | ||
| skip: [no-commit-to-branch] |
There was a problem hiding this comment.
This skips the ci from running this hook, but it still runs locally.
| autofix_prs: true | ||
| autoupdate_branch: 'pre-commit-autoupdate' | ||
| autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' | ||
| autoupdate_schedule: monthly |
There was a problem hiding this comment.
Shortest time is weekly, but monthly seemed fine. Can also extend to quarterly.
| autofix_commit_msg: | | ||
| [pre-commit.ci] auto fixes from pre-commit hooks | ||
| autofix_prs: true | ||
| autoupdate_branch: 'pre-commit-autoupdate' |
There was a problem hiding this comment.
Updates on a branch named pre-commit-autoupdate so it does not change our main branch.
|
I linked diffpy org at pre-commit.ci. I wasn't quite sure what else I needed to do? |
|
pre-commit.ci run |
|
From now on each new PR should automatically run this pre-commit once merged. Failures should be fixed with Caden's PR. |
Everything should be set up and good to go. We can test this after merging this PR and putting in a new PR to see if it runs this CI automatically. I tested it on my fork and it runs automatically. |
|
super, thanks @Sparks29032 |
|
@Sparks29032 @cadenmyers13 I tested this locally and it seemed to work (no commit to main after updating merged main). So @cadenmyers13 I think we need to migrate these changes also to diffpy.utils and diffpy.labpdfproc. Thanks so much @Sparks29032 for this! |
2 participants
Good to merge. Pre-commit CI is set up for this repo.
This removes the
pre-commit.ymlfile aspre-commit.cishould automatically run for every pull request after installation.