Skip to content

Conversation

@Sparks29032
Copy link
Collaborator

Remove mention of .sh for pre-commit and bump required python versions.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see inline

README.rst Outdated
familiar before using PDFmorph.

PDFmorph can be run with Python 2.7 and Python 3.5 or higher. We
PDFmorph can be run with Python 2.7 and Python 3.10 or higher. We
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove support for python 2.7

README.rst Outdated
hooks.

1. modify the permissions to executable on the bash script called ``prevent_commit_to_main.sh`` in this directory: ``chmod +x prevent_commit_to_main.sh``
1. Install pre-commit in your working environment with ``conda install pre-commit``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "....by typing ``conda...."

@sbillinge sbillinge merged commit afd8367 into diffpy:main Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants