Skip to content

Conversation

@dragonyanglong
Copy link
Contributor

No description provided.

@dragonyanglong
Copy link
Contributor Author

Hi @rozyczko , I created a PR for testing. Are these tests related with what you are trying to set up? It seems like failed at artifacts github releases

@rozyczko
Copy link
Contributor

This failure in uploading to Pypi is because this repo workflow permissions don't allow branches on your repo (@dragonyanglong ) to do the upload.
You either need to modify the permissions in the diffpy.pdffit2 repo or create a local branch

@dragonyanglong
Copy link
Contributor Author

modify the permissions in the diffpy.pdffit2 repo would be good. @rozyczko , Could you please show me where the permission is located, or the keywords to search for, at the setting page of a repo?

@dragonyanglong
Copy link
Contributor Author

Is it at the Actions tab? It seems like all permissions are allowed there.

image

@rozyczko
Copy link
Contributor

I believe this would help, but I haven't tested. This is in Actions/General

fork

@dragonyanglong
Copy link
Contributor Author

dragonyanglong commented Feb 27, 2023

@rozyczko , I tried changing the setting, but it doesn't make difference. Do we need to update anything in the https://github.com/diffpy/diffpy.pdffit2/blob/master/.github/workflows/build.yaml ?

    - name: Upload Artifacts GitHub releases
      uses: ncipollo/release-action@v1
      with:
        draft: false
        prerelease: true
        allowUpdates: true
        replacesArtifacts: true
        token: ${{ secrets.GITHUB_TOKEN }}
        artifacts: ${{ github.workspace }}/dist/*.whl
        tag: 1.4.0
        body: This is an alpha build of the pdffit2 library (1.4.0)

@rozyczko
Copy link
Contributor

Hmm I don't think we are missing anything, considering the local (non-forked) build runs fine
https://github.com/diffpy/diffpy.pdffit2/actions/runs/4280435199

The issue is with your fork not having proper permissions, I believe.
Can you create a local branch in this project and see if it is working as expected?

@dragonyanglong
Copy link
Contributor Author

I tried a testing PR at #13, it seems like fail for py3.10?

@dragonyanglong dragonyanglong merged commit 3ffea65 into diffpy:master Feb 28, 2023
@dragonyanglong dragonyanglong deleted the update_doc branch February 28, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants