Skip to content

Conversation

@ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Nov 24, 2025

What problem does this PR address?

Close #133

What should the reviewer(s) do?

To validate the built wheel:

python -m build
pip install .\dist\diffpy_pdffit2-0.0.1-cp313-cp313-win_amd64.whl --force-reinstall
python -c "import diffpy.pdffit2; print(diffpy.pdffit2.__version__)"
image

@ycexiao ycexiao marked this pull request as ready for review November 24, 2025 00:11
@ycexiao
Copy link
Contributor Author

ycexiao commented Nov 24, 2025

@sbillinge @stevenhua0320, it's ready for review.

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.97%. Comparing base (4773715) to head (9d752a7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   98.97%   98.97%           
=======================================
  Files           6        6           
  Lines        1270     1270           
=======================================
  Hits         1257     1257           
  Misses         13       13           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevenhua0320
Copy link
Contributor

@ycexiao It looks good to me, thanks for help!
@sbillinge ready for review, after this is tested on your local windows and if it is passed, we can start on the pre-release process.

@sbillinge sbillinge merged commit b657883 into diffpy:main Nov 24, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing cblas.dll in the Windows pypi wheel

3 participants