Skip to content

Conversation

@8bitsam
Copy link
Contributor

@8bitsam 8bitsam commented Jul 31, 2023

Update the conda-forge build config to support Python 3.8-3.10. This should ensure dependencies are updating when installing via conda-forge.
Closes #18

Ready for review and merge

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop 3.5 and 3.6 here too. In principle we are only supporting 3.9 - 3.11 atm. However, we still have code pinned at 3.7 (diffpy-cmi) so I would rather keep things down to 3.7, or else do 3.7 and 3.9 - 3.11.

There are two ways to get to Py3.11.

  • One is that, now we have it working locally in 3.10, we do it all again in 3.11, then we roll it out to conda-forge and make sure we can build it there.
  • Two is we take it all the way to conda-forge at 3.10 and test that we know how to make that work, then we do the work to take it to 3.11 after that.

I don't have a good answer to that, but I think that it may be quick to get it going on 3.11 (maybe it just runs locally now you know how to build it), so it might be worth trying that. If it just goes, then let's go for broke and bring it up to date with 3.11. If there are things to fix to make it run in 3.11, then go back to "Two"? What do you think?

@dragonyanglong
Copy link
Contributor

I agree with choice One. py3.9 to 3.10 needs some work, but py3.10 and py3.11 are similar.

@sbillinge
Copy link
Contributor

This is failing CI. A quick look suggests that the path to the release artifact may be incorrectly specified.

Also, it seems to be wanting to make a 1.4.0 release but don't we want to bump it to 1.4.1?

@dragonyanglong @8bitsam @robothamevan

@8bitsam
Copy link
Contributor Author

8bitsam commented Aug 1, 2023

I bumped to 1.4.1, but still need to check to make sure the test passes. I changed the build.yaml file based on github's recommendations for fixing the error that appeared in the test.

@sbillinge sbillinge merged commit 22b1c9f into diffpy:master Aug 2, 2023
@sbillinge
Copy link
Contributor

sbillinge commented Dec 2, 2023 via email

@8bitsam 8bitsam deleted the fixes-py310 branch July 8, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when installing pdffit2 via conda-forge then running a fit on pdfgui

3 participants