Skip to content

Updated to Python 3.11#22

Merged
sbillinge merged 4 commits intodiffpy:masterfrom
8bitsam:master
Jan 12, 2024
Merged

Updated to Python 3.11#22
sbillinge merged 4 commits intodiffpy:masterfrom
8bitsam:master

Conversation

@8bitsam
Copy link
Copy Markdown
Contributor

@8bitsam 8bitsam commented Jan 1, 2024

Update the conda-forge build config to support Python 3.11. This should ensure dependencies are updating when installing via conda-forge.
Installation using pip and running the built in tests were both successful. It doesn't seem like any C++ updates were needed.

Ready for review and merge

@sbillinge
Copy link
Copy Markdown
Contributor

@8bitsam , this looks good. What are the steps we have to do to test it and release it? I remember that I have to do some stuff, but I don't remember what!

Are there any issues taking it to python 3.12? If not, can we do that?

We need to do the same work so that the PDFgui gui program also gets updated to 3.11 and/or 3.12 so we can have them working together in latest python versions. We can then drop support for 3.8 and even 3.9.

@sbillinge sbillinge merged commit 0e31dd8 into diffpy:master Jan 12, 2024
@8bitsam
Copy link
Copy Markdown
Contributor Author

8bitsam commented Jan 13, 2024

For testing, I ran the built-in Python tests which passed on my end. I think we should be good to release it now, which can be done through rever.

I just put out a new PR for Python 3.12, which seems to work fine, the same as 3.11.

@sbillinge
Copy link
Copy Markdown
Contributor

sbillinge commented Jan 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants