Updated to Python 3.11#22
Merged
sbillinge merged 4 commits intodiffpy:masterfrom Jan 12, 2024
Merged
Conversation
Contributor
|
@8bitsam , this looks good. What are the steps we have to do to test it and release it? I remember that I have to do some stuff, but I don't remember what! Are there any issues taking it to python 3.12? If not, can we do that? We need to do the same work so that the PDFgui gui program also gets updated to 3.11 and/or 3.12 so we can have them working together in latest python versions. We can then drop support for 3.8 and even 3.9. |
Contributor
Author
|
For testing, I ran the built-in Python tests which passed on my end. I think we should be good to release it now, which can be done through rever. I just put out a new PR for Python 3.12, which seems to work fine, the same as 3.11. |
Contributor
|
great, thanks.
We are getting this error a bunch when we run PDFgui in python 3.9...
Traceback (most recent call last):
File
"C:\Users\simon\micromamba\envs\pdfgui2\lib\site-packages\diffpy\pdfgui\gui\errorwrapper.py",
line 62, in _f
return func(*args, **kwargs)
File
"C:\Users\simon\micromamba\envs\pdfgui2\lib\site-packages\diffpy\pdfgui\gui\phaseconstraintspanel.py",
line 473, in fillCells
gridutils.quickResizeColumns(self.gridAtoms, self._selectedCells)
File
"C:\Users\simon\micromamba\envs\pdfgui2\lib\site-packages\diffpy\utils\wx\gridutils.py",
line 123, in quickResizeColumns
dc = wx.ScreenDC()
NameError: name 'wx' is not defined
The packages were installed following the instructions on diffpy.org:
https://www.diffpy.org/products/pdfgui.html
I am not sure what is going on. wx is calling a helper function in
diffpy.utils which imports wx then can't find it....
However, it may be a better use of time to try and update PDFgui to 3.11 or
3.12 and then change the instructions? Please could you maybe have a look
at that and make branches? It will be hard for you to do good testing
because you don't do refinements, but if we have versions that can be
installed in 3.10, 3.11 and 3.12 environments, we can start doing our
refinements with these to test that? Would you mind doing that?
S
…On Sat, Jan 13, 2024 at 1:45 PM Sam Andrello ***@***.***> wrote:
For testing, I ran the built-in Python tests which passed on my end. I
think we should be good to release it now, which can be done through rever.
I just put out a new PR for Python 3.12, which seems to work fine, the
same as 3.11.
—
Reply to this email directly, view it on GitHub
<#22 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUMNDYOUSXJYQHMV7TLYOLI2TAVCNFSM6AAAAABBJLXFDOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJQGY4TGMRRGU>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
--
Simon Billinge
Professor,
Department of Applied Physics and Applied Mathematics
Columbia University
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the conda-forge build config to support Python 3.11. This should ensure dependencies are updating when installing via conda-forge.
Installation using pip and running the built in tests were both successful. It doesn't seem like any C++ updates were needed.
Ready for review and merge