Skip to content

Fix copy paste bytes for wxpython#50

Merged
sbillinge merged 1 commit intodiffpy:nextfrom
dragonyanglong:fix_copy_tree
May 21, 2021
Merged

Fix copy paste bytes for wxpython#50
sbillinge merged 1 commit intodiffpy:nextfrom
dragonyanglong:fix_copy_tree

Conversation

@dragonyanglong
Copy link
Copy Markdown
Collaborator

This PR is for fixing the copy-paste fit tree item bug. Since py3 bytes cannot combine with str together as in py2, thus using base64 to convert bytes to str first then follow the old strategy for copy-paste function.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 25, 2020

Codecov Report

Merging #50 (a00ff15) into next (a9de126) will decrease coverage by 0.00%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #50      +/-   ##
==========================================
- Coverage   57.56%   57.56%   -0.01%     
==========================================
  Files          95       95              
  Lines       10985    10988       +3     
==========================================
+ Hits         6324     6325       +1     
- Misses       4661     4663       +2     
Impacted Files Coverage Δ
src/diffpy/pdfgui/gui/fittree.py 45.31% <10.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9de126...a00ff15. Read the comment docs.

@dragonyanglong
Copy link
Copy Markdown
Collaborator Author

@sbillinge @pavoljuhas . Please review and merge.

@sbillinge sbillinge merged commit 1f03042 into diffpy:next May 21, 2021
@sbillinge sbillinge deleted the fix_copy_tree branch May 21, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants