Skip to content

MAINT: fix background color of parameter boxes#51

Merged
sbillinge merged 1 commit intodiffpy:nextfrom
dragonyanglong:fix_param_box_color
May 21, 2021
Merged

MAINT: fix background color of parameter boxes#51
sbillinge merged 1 commit intodiffpy:nextfrom
dragonyanglong:fix_param_box_color

Conversation

@dragonyanglong
Copy link
Copy Markdown
Collaborator

In py3 wxpython, background color is not white even if no constrains applied.

This PR closes #45

In py3 wxpython, background color is not white even if no constrains applied.
@dragonyanglong
Copy link
Copy Markdown
Collaborator Author

In old py2 wxpython, txtbg is (255, 255, 255, 255). But in py3 wxpython, it is (-1, -1, -1, 255)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2020

Codecov Report

Merging #51 (0a09b56) into next (a9de126) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next      #51   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files          95       95           
  Lines       10985    10985           
=======================================
  Hits         6324     6324           
  Misses       4661     4661           
Impacted Files Coverage Δ
src/diffpy/pdfgui/gui/phaseconfigurepanel.py 53.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9de126...0a09b56. Read the comment docs.

@sbillinge sbillinge merged commit f4f3a18 into diffpy:next May 21, 2021
@sbillinge sbillinge deleted the fix_param_box_color branch May 21, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants