deprecate: Deprecate Profile class and SimpleRecipe class#155
Merged
sbillinge merged 8 commits intodiffpy:v3.3.0from Feb 20, 2026
Merged
deprecate: Deprecate Profile class and SimpleRecipe class#155sbillinge merged 8 commits intodiffpy:v3.3.0from
Profile class and SimpleRecipe class#155sbillinge merged 8 commits intodiffpy:v3.3.0from
Conversation
cadenmyers13
commented
Feb 19, 2026
src/diffpy/srfit/fitbase/profile.py
Outdated
|
|
||
|
|
||
| def rebinArray(A, xold, xnew): | ||
| def rebin_array(A, xold, xnew): |
Contributor
Author
There was a problem hiding this comment.
I changed this name. It is only used in the file and this doesn't seem like something people are accessing. Maybe this should be a private function? seems more like a helper to me
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3.3.0 #155 +/- ##
==========================================
+ Coverage 69.97% 70.55% +0.58%
==========================================
Files 25 25
Lines 3527 3597 +70
==========================================
+ Hits 2468 2538 +70
Misses 1059 1059
🚀 New features to boost your workflow:
|
cadenmyers13
commented
Feb 19, 2026
| self.assertTrue(array_equal(x, prof.x)) | ||
| self.assertTrue(array_equal(y, prof.y)) | ||
| self.assertTrue(array_equal(dy, prof.dy)) | ||
| return |
Contributor
Author
There was a problem hiding this comment.
I duplicated part of this ^ function so only one deprecation warning is emitted.
Contributor
Author
|
@sbillinge ready for review. see a couple of my inline comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.