Skip to content

Deprecate: deprecate all methods of parameters.py#170

Merged
sbillinge merged 8 commits intodiffpy:v3.3.0from
cadenmyers13:param-dep
Mar 16, 2026
Merged

Deprecate: deprecate all methods of parameters.py#170
sbillinge merged 8 commits intodiffpy:v3.3.0from
cadenmyers13:param-dep

Conversation

@cadenmyers13
Copy link
Contributor

In addition to method deprecation, I replaced Attributes with Parameters in function docstrings everywhere. Also, turned processMetaData into a private function.

@cadenmyers13
Copy link
Contributor Author

@sbillinge ready for review

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.60%. Comparing base (c115478) to head (ec2b2af).
⚠️ Report is 10 commits behind head on v3.3.0.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3.3.0     #170      +/-   ##
==========================================
+ Coverage   78.40%   78.60%   +0.19%     
==========================================
  Files          24       24              
  Lines        3700     3734      +34     
==========================================
+ Hits         2901     2935      +34     
  Misses        799      799              
Files with missing lines Coverage Δ
tests/test_constraint.py 98.30% <100.00%> (ø)
tests/test_parameter.py 98.86% <100.00%> (+0.71%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge merged commit 6012bb2 into diffpy:v3.3.0 Mar 16, 2026
6 checks passed
@sbillinge
Copy link
Contributor

Nice. Thanks for the tests and the careful thought

@cadenmyers13 cadenmyers13 deleted the param-dep branch March 16, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants