style: fix flake8 errors for config.py #10
Conversation
|
@sbillinge ready for review |
| "header": "f", | ||
| "h": "mask the edge pixels, first four means the number of pixels masked in each edge \ | ||
| (left, right, top, bottom), the last one is the radius of a region masked around the corner", | ||
| "h": ( |
There was a problem hiding this comment.
let's take this opportunity to rename variables to something more interpretable (wild guess here but this is a help message?). Same with n and d below (not help messages but rename.
As in the previous review, to separate possible breaking changes and linting changes, it is ok to put in a FIXME and return later.
There was a problem hiding this comment.
Here is a segment from the beginning of the file:
# Text to display before the argument help
_description = """Description of configurations
"""
# Text to display after the argument help
_epilog = """
"""
"""
optdata contains these keys:
these args will be passed to argparse, see the documents of argparse for
detail information
'f': full, (positional)
's': short
'h': help
't': type
'a': action
'n': nargs
'd': default
'c': choices
'r': required
'de': dest
'co': const
"""
_optdatanamedict = {
"h": "help",
"t": "type",
"a": "action",
"n": "nargs",
"d": "default",
"c": "choices",
"r": "required",
"de": "dest",
"co": "const",
}
It seems like these variable names are deliberately named. They stand for help, nargs, and default respectively, but they seem to be eventually passed into the _optdatanamedict variable later and used. Do you still want me to rename them?
There was a problem hiding this comment.
let's leave them then. More trouble than it is worth to rename them I think.
2 participants
No description provided.