skpkg: setup CI after migrating tests, src, requirements, and .github folder #12
Conversation
| @@ -0,0 +1,163 @@ | |||
| name: Release on GitHub | |||
There was a problem hiding this comment.
Since this is a private package that we are not releasing on PyPI/CF, I just copied the build-wheel file from pdfgetx but with some minor modifications. Let me know if you want any of this changed.
| @@ -0,0 +1,163 @@ | |||
| name: Release on GitHub | |||
| @@ -1,4 +1,3 @@ | |||
| numpy | |||
| configparser | |||
There was a problem hiding this comment.
I believe this is built in for python 3.
There was a problem hiding this comment.
in that case, let's make sure we remove any imports of it in the code.
There was a problem hiding this comment.
Sorry, I meant that no additional installations are required as it's built into the Python standard library, but I believe that you still need to import it.
src/diffpy/__init__.py
Outdated
| # All rights reserved. | ||
| # | ||
| # File coded by: Xiaohao Yang | ||
| # File coded by: Billinge Group members and community contributors. |
There was a problem hiding this comment.
Should I revert this back to Xiaohao Yang?
There was a problem hiding this comment.
Please do both. So Xiahao Yang and Billinge group...
There was a problem hiding this comment.
@zmx27 please respond to all comments to make it easier for me to see how you responded.
|
@sbillinge ready for review |
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
This looks great! Please see comments and then I can merge. Please can you help the other members of the team when they do this step and give them the same review feedback?
Thanks so much.
| @@ -1,4 +1,3 @@ | |||
| numpy | |||
| configparser | |||
There was a problem hiding this comment.
in that case, let's make sure we remove any imports of it in the code.
src/diffpy/__init__.py
Outdated
| # dpx.confutils by Simon J. L. Billinge group | ||
| # (c) 2013 Trustees of the Columbia University | ||
| # in the City of New York. All rights reserved. | ||
| # (c) 2025 The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
everywhere you have a copyright statement, we need to do the full date-range, so it should be 2013-2025
src/diffpy/__init__.py
Outdated
| # All rights reserved. | ||
| # | ||
| # File coded by: Xiaohao Yang | ||
| # File coded by: Billinge Group members and community contributors. |
There was a problem hiding this comment.
Please do both. So Xiahao Yang and Billinge group...
src/diffpy/srxconfutils/__init__.py
Outdated
| # dpx.confutils by Simon J. L. Billinge group | ||
| # (c) 2013 Trustees of the Columbia University | ||
| # in the City of New York. All rights reserved. | ||
| # (c) 2025 The Trustees of Columbia University in the City of New York. |
There was a problem hiding this comment.
please see above for how to handle this statement at the top of the files.
src/diffpy/srxconfutils/__init__.py
Outdated
| # See LICENSE.rst for license information. | ||
| # | ||
| ############################################################################## | ||
| """Configuration utilities for dpx project. |
There was a problem hiding this comment.
I think it won't be called dpx any more. Just delete dpx here I think.
|
@sbillinge ready for review |
|
nicely done there |
2 participants
No description provided.