-
Notifications
You must be signed in to change notification settings - Fork 1
lint check by pre-commit in level 3 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@stevenhua0320 Thanks! @sbillinge ready for review of black edits. |
|
@stevenhua0320 please confirm that no manual edits were done in this PR, just auto-commits. Also, please can you copy-paste what you get when you run pre-commit so we can see what is done and what is left? If there are not manual edits, I can merge though. |
Yes, I made this branch in particular for auto-correction from pre-commit. The log below is what it does after the auto-precommit.
reformatted dpx/srxplanargui/live.py All done! ✨ 🍰 ✨ flake8...................................................................Failed
:446: SyntaxWarning: invalid escape sequence '\d' isort....................................................................Failed
Fixing /Users/huarundong/dbs/diffpy.srxplanargui/dpx/srxplanargui/imageplot.py nbstripout...........................................(no files to check)Skipped
|
|
@stevenhua0320 Looks like there are a few autofixes that are shown here (isort and black), can you make sure these are on this PR? Then post the pre-commit message. Also can you format the codeblock like this so its easier to read? |
|
``
Yes, I have confirmed that they are on this PR since they are the files included in the commit. Moreover, I run pre-commit on all the files once again and they still pop up. Moreover, when I check using |
|
@cadenmyers13 Hi Caden, I have managed to resolve the fighting black and isort issue by suppressing black to do modification. There is another file that made by auto-fix so I made another push here. Here is the pre-commit message now. |
|
@stevenhua0320 thanks Steven. @sbillinge this is ready for review. See Steven's comment for pre commit message. |
@cadenmyers13
-First round of auto-correction of lint check by pre-commit