Add PyPI/GitHub checklist via Issues (closed due to unnecessary commits)#106
Closed
bobleesj wants to merge 15 commits intodiffpy:mainfrom
bobleesj:issue
Closed
Add PyPI/GitHub checklist via Issues (closed due to unnecessary commits)#106bobleesj wants to merge 15 commits intodiffpy:mainfrom bobleesj:issue
bobleesj wants to merge 15 commits intodiffpy:mainfrom
bobleesj:issue
Conversation
bobleesj
commented
Oct 19, 2024
| - [ ] Grammar and writing quality have been checked. | ||
| - [ ] License information is verified. If you are unsure, please comment below. | ||
|
|
||
| Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as version information and details about the pre-release. No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
checks license, installation instructions, badges, docs, grammar, writing quality, PR/issues, cookiecutting status.
Contributor
Author
|
Ready for review @sbillinge |
Contributor
Author
|
Added news to pass the CI.. |
sbillinge
reviewed
Oct 19, 2024
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
I like the checklist. I have a few edit suggestsions. But this PR seems to be a bit dirty....lots of old commits. Do you know why? Is there a way to remake the PR with just one commit on it?
Contributor
Author
|
@sbillinge Yes, a new PR is created instead: #107 I must have pushed some commits to |
bobleesj
changed the title
bobleesj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please suggest for any additional items in the checklist that could be added.
@sbillinge @alisnwu