function lift_data and initialize_arrays#25
Conversation
|
|
||
| """ | ||
| data_input = np.asarray(data_input) | ||
| return data_input - (np.min(data_input[:]) * lift) |
There was a problem hiding this comment.
doesn't data_input - (np.min(data_input) * lift) work? It is easier to read.
There was a problem hiding this comment.
It does. I will change it
| np.testing.assert_allclose(actual, expected, rtol=1e-03) | ||
|
|
||
|
|
||
| tld = [([[[1, -1, 1], [0, 0, 0], [2, 10, -3]], 1], [[4, 2, 4], [3, 3, 3], [5, 13, 0]]), |
There was a problem hiding this comment.
to make these easier to read, maybe make the inputs and outputs as tuples, something like:
tld = [
(([[1, -1, 1], [0, 0, 0], [2, 10, -3]], 1),
([4, 2, 4], [3, 3, 3], [5, 13, 0])),
(([[1, -1, 1], [0, 0, 0], [2, 10, -3]], 0),
([1, -1, 1], [0, 0, 0], [2, 10, -3])),
and so on.
|
@aajayi-21 a general comment I have is that it is very difficult for me to review this code because I don't have a kind of high level view of what all the pieces are, something that looks like a flow diagram that takes me from what is handed in at the beginning, through all the steps, to what is handed out. I feel that we could maybe come up with a better organization and data structures if we had this. Could you work on that? It can be hand-drawn with a pen and upload a photo to the issues or sthg like that. |
…nged expections of test cases to reflect changed bahvior
2 participants
No description provided.