function create_components#34
Merged
sbillinge merged 3 commits intodiffpy:mainfrom Aug 1, 2023
Merged
Conversation
sbillinge
reviewed
Aug 1, 2023
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
This is great! Please see a couple of tiny comments. ComponentSignal is merged so the next push and I think this can go in.
Excellent, we are making progress......
| def test_create_components(tcc): | ||
| actual = create_components(tcc[0], tcc[1], tcc[2], tcc[3]) | ||
| assert len(actual) == tcc[0] | ||
| for c in actual: |
Contributor
There was a problem hiding this comment.
I think the first and last section is just testing the constructor of the ComponentSignals container. In other words, if the constructor is working, this will pass, and if not it won't. The other two are just testing the set method in there. So I suggest to move these to the tests for the ComponentSignal and leaave them out here. You could also add some tests there for edge cases if you can think of any.
There is honeslty not much to test here, so line 164 may be enough.
Fixed tests, refactored name, added raised error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the ComponentSignal is merged into main, I can merge main into this branch and create_components will function successfully