PR Part 1/3 of Cookiecutter pre-commit workflow#53
Merged
sbillinge merged 4 commits intodiffpy:cookiefrom Aug 1, 2024
bobleesj:black
Merged
PR Part 1/3 of Cookiecutter pre-commit workflow#53sbillinge merged 4 commits intodiffpy:cookiefrom bobleesj:black
sbillinge merged 4 commits intodiffpy:cookiefrom
bobleesj:black
Conversation
bobleesj
changed the title
Contributor
Author
|
@sbillinge Please review |
|
@bobleesj make sure you are using the right .flake8 file. |
Contributor
Author
|
@Tieqiong .flake8 file has been fixed. |
sbillinge
approved these changes
Aug 1, 2024
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
This looks great @bobleesj thanks! Great start!
I created a new branch , cookie, which we will use for the new base. Please fetch upstream and build new branches off cookie, and also make PRs into cookie. When everything is finished we will merge it into main.
Contributor
Author
|
Will make PRs to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the first portion of the pre-commit workflow provided here: https://github.com/Billingegroup/cookiecutter
As instructed:
blackconfig inpyproject.tomlblack diffpyblack ..flake8Should I manually modify the files with
flake8errors here? I saw the instruction forblackbut did not see the explicit instruction for runningflake8from Step 1-10.