Skip to content

Part 3/3 of Cookiecutter pre-commit workflow (precommit)#55

Merged
sbillinge merged 3 commits intodiffpy:cookiefrom
bobleesj:precommit
Aug 2, 2024
Merged

Part 3/3 of Cookiecutter pre-commit workflow (precommit)#55
sbillinge merged 3 commits intodiffpy:cookiefrom
bobleesj:precommit

Conversation

@bobleesj
Copy link
Copy Markdown
Contributor

@bobleesj bobleesj commented Aug 2, 2024

The last precommit section in Step 11-17.

Below, precommit screenshot:

Screenshot 2024-08-01 at 11 03 46 PM

This precommit branch is continued from flake8(has not been merged as of now). Is this still okay? @sbillinge - I am asking this because I have not submitted another PR before my previous branch has been merged.

@bobleesj
Copy link
Copy Markdown
Contributor Author

bobleesj commented Aug 2, 2024

Great, precommit check works.

@sbillinge
Copy link
Copy Markdown
Contributor

@bobleesj this is great! Thanks, I merged.

@sbillinge sbillinge merged commit 504568e into diffpy:cookie Aug 2, 2024
@bobleesj bobleesj deleted the precommit branch August 2, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants