Cookiecutter: add news and fix conf.py and liense.rst in doc#62
Cookiecutter: add news and fix conf.py and liense.rst in doc#62sbillinge merged 11 commits intodiffpy:cookiefrom bobleesj:sign-off
Conversation
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
this looks good. Please see the inline comments.
|
|
||
| For more information please visit the diffpy web-page at | ||
| http://diffpy.org or email Prof. Simon Billinge at sb2896@columbia.edu. | ||
| Copyright (c) {% now 'utc', '%Y' %}, The Trustees of Columbia University in |
There was a problem hiding this comment.
add earlier begin date and make sure it is consistent between the readme and here.
There was a problem hiding this comment.
Added 2009 (earlier date) to where we have copyright
|
@bobleesj please can you update the toml. I think this is not 5 in development but more like 3 or 4 |
There was a problem hiding this comment.
@sbillinge Please review
- Properly rename to
diffpy.snmfinconf.py - Fix toml - fixed dev status from 5 to 4
- Add code linting in news
- Add Python support in news
- Add earlier year to current year ex) 2009-2024 in copyright
- doc locally running
In the following PR, I want to try hosting the doc via GH Pages. Does it need to be merged to main? I will continue to check any bad files by cross-checking with signed-off repos.
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
Just one last thing. I am guessing the work started no earlier than 2017 or so and possibly later so we don't want copyright statements going back to 2009?
|
From https://github.com/diffpy/diffpy.snmf/blob/main/doc/source/license.rst Perhaps it's referring to the entire DiffPy project?
|
|
I see your first commit in 2023: Would it be 2023 then? @sbillinge |
bobleesj
left a comment
bobleesj
left a comment
There was a problem hiding this comment.
Reviewed - now 2023-2024.
2 participants
conf.pyandlicense.rstunderdoc, cross-checkeddiffpy.pdffit2Should it be now merged to
mainso that I host the doc online? @sbillingeI will continue standardizing and editing/removing files.
Not sure why I need your approval to run 2 workflows in this PR below?