Fix OverlapCalculator rmin#26
Merged
pavoljuhas merged 2 commits intodiffpy:masterfrom Apr 24, 2019
Merged
Conversation
Not passing yet - expose rmin bug.
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 88.39% 88.57% +0.17%
==========================================
Files 138 138
Lines 7507 7525 +18
Branches 526 526
==========================================
+ Hits 6636 6665 +29
+ Misses 675 663 -12
- Partials 196 197 +1
Continue to review full report at Codecov.
|
pavoljuhas
added a commit
that referenced
this pull request
Apr 24, 2019
* respect OverlapCalculator.rmin in overlap evaluation Resolve #26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect rmin value when evaluating atom radii overlap.