Skip to content

Add missing env update in SConstruct when PREFIX is not set#26

Merged
sbillinge merged 1 commit intodiffpy:mainfrom
clemisch:main
Oct 21, 2025
Merged

Add missing env update in SConstruct when PREFIX is not set#26
sbillinge merged 1 commit intodiffpy:mainfrom
clemisch:main

Conversation

@clemisch
Copy link
Copy Markdown
Contributor

Fixes #25

@sbillinge
Copy link
Copy Markdown
Contributor

@clemisch @vincefn do we know why this suddenly showed up, when it wasn't failing before? I'm happy to merge it if we don't think it breaks any other installation paths, but it would be nice to understand why it suddenly popped up after all these years.

@ezatterin
Copy link
Copy Markdown

Perhaps no one tried to build the library outside of a conda env or anything else exporting a PREFIX env variable :) Indeed if one is in a python venv running export CONDA_PREFIX=$VIRTUAL_ENV and building with sudo -E to preserve the env variables works fine.

@sbillinge
Copy link
Copy Markdown
Contributor

yes, makes sense. We are heading to a new release to catch the python 3.14 update, so I am happy to merge this. We will have to test that it doesn't break anything for the conda builds.

@sbillinge sbillinge merged commit a0a5e93 into diffpy:main Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install error with missing PREFIX

3 participants