Conversation
🦋 Changeset detectedLatest commit: 0b8bbca The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - themebuilder - www - |
Member
|
I tested with a validation tool on some random pages to see if there was more that should be fixed. Most pages had none. But I found some other cases we can consider fixing. /intro
/code/cli-config
Im guessing the Mønster/merking av lenker
Themebuilder
|
Collaborator
Author
This is indeed 3rd party stuff to preview code and out of reach for us unfortunately |
Barsnes
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4578
The issue was AvatarStack being
figureand then nested insidespan(that is display: flex anyway).Changed span to div.
Not sure if perhaps the underlying element for avatarstack should be span instead to avoid others running into this problem 🤔Edit: I have changed the underlying element in
AvatarStacktospan. It makes no difference other than now it won't fail html-validation for users putting it inside an outer span.The other issue is we wrap a link around the avatarstack to anchor link to the authors at the bottom of the page, but we also have automatic tabindex on the avatarStack, which is not allowed even if it is set to -1. Fixed by setting it to undefined instead of -1 in the component, and not use expandable where it is wrapped in a link.
Fixed the other issues of wrong heading level, properly url-encoded feedback urls, and divs inside a button in themebuilder