fix(tabs): onChange is not called when keyboard changes active tab#4616
fix(tabs): onChange is not called when keyboard changes active tab#4616
onChange is not called when keyboard changes active tab#4616Conversation
|
Preview deployments for this pull request: storybook - |
🦋 Changeset detectedLatest commit: 7980dce The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
We should test if this also fixes #4617 |
Would be surprised if it does, since this does not stop the change event from our web component |
If this is the best course, sure? Less complexity is always good :) What was the problem with the |
Summary
resolves #4605
I seems like this is an issue for react.
We could just remove the trusted line, but this make sure it keep the same functionality as before, but calls
onChangeif the users keyboard changes the value.I'm open to just removing the line, since we always want
onChangeto stay in sync with the actual active tab.Checks
pnpm changesetif relevant)