Conversation
🦋 Changeset detectedLatest commit: 4adaebe The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Preview deployments for this pull request: storybook - |
eirikbacker
approved these changes
Apr 7, 2026
Collaborator
Author
|
Can not merge this until whatever is causing the tests to fail during build has been fixed since there should be visual changes that needs to be checked in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while trying to fix the corner-gap issue in toggle-group, I discovered that
overflow-x: hiddenhad no effect due to user-agentmin-width: min-contentonfieldset.This pr set min-width to 0 and also margin-inline to 0 to overwrite the user-agent
margin-inline: 2px(this will cause a 2px visual change)We could alternatively fix the gap instead of fixing the scroll by removing overflow-x 🤷