fix(Popover): better handle esc when dialog is open

[eirikbacker]

Fix: Popover no longer closes on "Escape" when a Dialog element is open above it

[changeset-bot]

🦋 Changeset detected

Latest commit: 43ea676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@digdir/designsystemet-react	Patch
@digdir/designsystemet	Patch
@digdir/designsystemet-css	Patch
@digdir/designsystemet-types	Patch
@digdir/designsystemet-web	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Preview deployments for this pull request:

storybook - 7. May 2026 - 11:46

[Copilot]

Pull request overview

This PR updates the React Popover component’s Escape-key handling so it won’t close when another top-layer UI (notably an open Dialog) is above it, aligning behavior with expected top-layer semantics.

Changes:

• Update Popover Escape-key handler to only close when the Popover is considered top-layer.
• Add isTopLayer(...) helper to detect when a Dialog / other popover is above the current Popover.
• Add Storybook scenarios for Dropdown involving adjacent dialogs and nested dropdowns, plus a changeset entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
packages/react/src/components/popover/popover.tsx	Changes Escape handling to respect top-layer state and adds isTopLayer detection helper.
packages/react/src/components/dropdown/dropdown.stories.tsx	Adds Storybook stories to exercise dialog adjacency and nested dropdown scenarios.
.changeset/strange-yaks-burn.md	Adds a patch changeset describing the Popover Escape behavior fix.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mimarz]

Can we add a test for this? 🙏

[eirikbacker]

Can we add a test for this? 🙏

Please do 🤗 but, we should find another way to handle this, using popover="auto" to let the browser handle ESC-order as we can not 100% replicate the #top-layer computation anyway.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82bdd503-e7f6-48af-867f-f72d4a05edf7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

• Create PR with unit tests
• Commit unit tests in branch fix/popover-open-dialog-support

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

---

Generating unit tests... This may take up to 20 minutes.

[coderabbitai]

✅ Created PR with unit tests: #4861