Skip to content

fix(dialog): stop sending bubbled close events#4899

Merged
mimarz merged 2 commits into
mainfrom
dialog/event
May 19, 2026
Merged

fix(dialog): stop sending bubbled close events#4899
mimarz merged 2 commits into
mainfrom
dialog/event

Conversation

@Barsnes
Copy link
Copy Markdown
Member

@Barsnes Barsnes commented May 19, 2026

Summary

resolves #4892

Checks

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 19, 2026

🦋 Changeset detected

Latest commit: c37f81c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-react Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-types Patch
@digdir/designsystemet-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 745f44c0-4763-4b32-b2bb-f291dca0310c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dialog/event

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Preview deployments for this pull request:

storybook - 19. May 2026 - 07:56

@Barsnes Barsnes marked this pull request as ready for review May 19, 2026 06:07
Copy link
Copy Markdown
Contributor

@eirikbacker eirikbacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👏

@mimarz mimarz merged commit 6f65300 into main May 19, 2026
19 checks passed
@mimarz mimarz deleted the dialog/event branch May 19, 2026 06:18
@github-actions github-actions Bot mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing a nested Dialog also closes its parent Dialog

3 participants