Skip to content

fix(popover): calculate arrow size based on css custom property#4951

Merged
eirikbacker merged 6 commits into
mainfrom
fix/popover-arrow-size
Jun 5, 2026
Merged

fix(popover): calculate arrow size based on css custom property#4951
eirikbacker merged 6 commits into
mainfrom
fix/popover-arrow-size

Conversation

@eirikbacker
Copy link
Copy Markdown
Contributor

Resolves #4940
Replaces #4931

@eirikbacker eirikbacker self-assigned this Jun 4, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 4, 2026

🦋 Changeset detected

Latest commit: e6f3b00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@digdir/designsystemet-web Patch
@digdir/designsystemet Patch
@digdir/designsystemet-css Patch
@digdir/designsystemet-types Patch
@digdir/designsystemet-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Preview deployments for this pull request:

storybook - 5. Jun 2026 - 08:29

Comment thread .changeset/fine-states-poke.md Outdated
Co-authored-by: Michael Marszalek <mimarz@gmail.com>
@eirikbacker eirikbacker requested a review from mimarz June 4, 2026 12:33
Copy link
Copy Markdown
Collaborator

@mimarz mimarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This was a smart solution. Thanks for taking the time to fix this @eirikbacker 👏

Comment thread packages/web/src/popover/popover.ts Outdated

This comment was marked as outdated.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@eirikbacker eirikbacker merged commit ae3a92b into main Jun 5, 2026
17 of 18 checks passed
@eirikbacker eirikbacker deleted the fix/popover-arrow-size branch June 5, 2026 06:31
@github-actions github-actions Bot mentioned this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce popover arrow size variable

4 participants