Skip to content

Feature flag, buffer pooling fix #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

Feature flag, buffer pooling fix #2469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8250587
change e2b template version
breardon2011 Nov 20, 2025
d53a6b0
add buffer pooling fix, feature flag
breardon2011 Nov 20, 2025
e0ed6a6
Merge branch 'develop' of https://github.com/diggerhq/digger into cho…
breardon2011 Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sandbox-sidecar/src/runners/e2bRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,15 @@ export class E2BSandboxRunner implements SandboxRunner {
// Write the config archive
const archivePath = `${workDir}/bundle.tar.gz`;
const archiveBuffer = Buffer.from(job.payload.configArchive, "base64");
await sandbox.files.write(archivePath, archiveBuffer.buffer);

// IMPORTANT: Extract exact-sized ArrayBuffer to avoid writing extra padding bytes
// archiveBuffer.buffer can include unused bytes if the Buffer is a slice/view of a larger ArrayBuffer
// This was causing intermittent "gzip: invalid header" errors
const exactBuffer = archiveBuffer.buffer.slice(
archiveBuffer.byteOffset,
archiveBuffer.byteOffset + archiveBuffer.byteLength
);
await sandbox.files.write(archivePath, exactBuffer);

// Extract the archive (excluding any existing state files to avoid conflicts)
// Use gunzip + tar separately for better compatibility across tar versions
Expand Down
5 changes: 3 additions & 2 deletions ui/src/components/UnitCreateForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ export default function UnitCreateForm({
const [isCreating, setIsCreating] = React.useState(false)
const [error, setError] = React.useState<string | null>(null)

// Remote runs beta is now always enabled
const remoteRunsEnabled = true
// Remote runs are gated by localStorage flag for beta testing
// Set localStorage.setItem('REMOTE_RUNS', 'true') to enable
const remoteRunsEnabled = typeof window !== 'undefined' && localStorage.getItem('REMOTE_RUNS') === 'true'

const handleCreate = async () => {
if (!unitName.trim()) return
Expand Down
Loading