Skip to content

use goroutines during checks to fix the latency issue #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
motatoes merged 3 commits into from
Dec 6, 2025
Merged

use goroutines during checks to fix the latency issue #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc18974
use goroutines during checks to fix the latency issue
motatoes Dec 5, 2025
1428fe2
remove the skipping for orchestrator releaser
motatoes Dec 5, 2025
339b746
use depot for test builds
motatoes Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions .github/workflows/backend_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,18 @@ jobs:
uses: actions/checkout@v4

- name: Test that the docker image still builds successfully
run: |
export COMMIT_SHA=$(git rev-parse --short HEAD)
docker build -t testingbuild:latest --build-arg COMMIT_SHA=${COMMIT_SHA} . -f Dockerfile_backend
uses: depot/setup-action@v1

- name: Build Docker image with Depot
uses: depot/build-push-action@v1
with:
project: f11hp4hlmg
token: ${{ secrets.DEPOT_TOKEN }}
context: .
file: ./Dockerfile_backend
push: false
build-args: |
COMMIT_SHA=${{ github.sha }}

- name: Deps
run: go get -v ./...
Expand Down
15 changes: 12 additions & 3 deletions .github/workflows/ee_backend_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,18 @@ jobs:
uses: actions/checkout@v4

- name: Test that the docker image still builds successfully
run: |
export COMMIT_SHA=$(git rev-parse --short HEAD)
docker build -t testingbuild:latest --build-arg COMMIT_SHA=${COMMIT_SHA} . -f Dockerfile_backend
uses: depot/setup-action@v1

- name: Build Docker image with Depot
uses: depot/build-push-action@v1
with:
project: kcld4zgwzx
token: ${{ secrets.DEPOT_TOKEN }}
context: .
file: ./Dockerfile_backend_ee
push: false
build-args: |
COMMIT_SHA=${{ github.sha }}

- name: Deps
run: go get -v ./...
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/update-helm-on-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ jobs:
SERVICE="backend-ee"
VERSION="${TAG_NAME##backend-ee/}"
YAML_PATH=".taco-orchestrator.digger.image.tag"
echo "Backend EE detected - skipping helm update (disabled for manual control)"
exit 0
elif [[ $TAG_NAME == drift/v* ]]; then
SERVICE="drift"
VERSION="${TAG_NAME##drift/}"
Expand Down
59 changes: 34 additions & 25 deletions backend/controllers/projects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,18 +1031,22 @@ func (d DiggerController) SetJobStatusForProject(c *gin.Context) {
"checkRunId", refreshedBatch.CheckRunId,
"vcs", refreshedBatch.VCS,
"jobId", jobId)
err = UpdateCheckRunForBatch(d.GithubClientProvider, refreshedBatch)
if err != nil {
slog.Warn("DIAGNOSTIC #7: Failed to update GitHub Check Run for batch (non-fatal)",
"batchId", batch.ID,
"checkRunId", refreshedBatch.CheckRunId,
"vcs", refreshedBatch.VCS,
"error", err,
"errorType", fmt.Sprintf("%T", err))
// Continue processing - Check Run update is best-effort, not critical
} else {
slog.Debug("Successfully updated GitHub Check Run for batch", "batchId", batch.ID)
}

// performing this in a goroutine to avoid huge latencies (added by ai summary gen)
go func() {
err = UpdateCheckRunForBatch(d.GithubClientProvider, refreshedBatch)
if err != nil {
slog.Warn("DIAGNOSTIC #7: Failed to update GitHub Check Run for batch (non-fatal)",
"batchId", batch.ID,
"checkRunId", refreshedBatch.CheckRunId,
"vcs", refreshedBatch.VCS,
"error", err,
"errorType", fmt.Sprintf("%T", err))
// Continue processing - Check Run update is best-effort, not critical
} else {
slog.Debug("Successfully updated GitHub Check Run for batch", "batchId", batch.ID)
}
}()

slog.Debug("Fetching refreshed job", "jobId", jobId, "batchId", batch.ID)
refreshedJob, err := models.DB.GetDiggerJob(jobId)
Expand All @@ -1060,19 +1064,24 @@ func (d DiggerController) SetJobStatusForProject(c *gin.Context) {
"checkRunId", refreshedJob.CheckRunId,
"vcs", refreshedJob.Batch.VCS,
"batchId", batch.ID)
err = UpdateCheckRunForJob(d.GithubClientProvider, refreshedJob)
if err != nil {
slog.Warn("DIAGNOSTIC #9: Failed to update GitHub Check Run for job (non-fatal)",
"jobId", jobId,
"checkRunId", refreshedJob.CheckRunId,
"batchId", batch.ID,
"vcs", refreshedJob.Batch.VCS,
"error", err,
"errorType", fmt.Sprintf("%T", err))
// Continue processing - Check Run update is best-effort, not critical
} else {
slog.Debug("Successfully updated GitHub Check Run for job", "jobId", jobId)
}

// performing this in a goroutine to avoid huge latencies (added by ai summary gen)
go func() {
err = UpdateCheckRunForJob(d.GithubClientProvider, refreshedJob)
if err != nil {
slog.Warn("DIAGNOSTIC #9: Failed to update GitHub Check Run for job (non-fatal)",
"jobId", jobId,
"checkRunId", refreshedJob.CheckRunId,
"batchId", batch.ID,
"vcs", refreshedJob.Batch.VCS,
"error", err,
"errorType", fmt.Sprintf("%T", err))
// Continue processing - Check Run update is best-effort, not critical
} else {
slog.Debug("Successfully updated GitHub Check Run for job", "jobId", jobId)
}
}()


if batch.ReportTerraformOutputs {
slog.Info("Generating Terraform outputs summary", "batchId", batch.ID)
Expand Down
Loading