split DiggerConfig into two parts, one for yaml parsing and one for config itself #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veziak
requested review from
Spartakovic and
motatoes
and removed request for
Spartakovic
Spartakovic
reviewed
Jun 8, 2023
Spartakovic
reviewed
Jun 8, 2023
Spartakovic
reviewed
Jun 8, 2023
|
all "Config" structs should move to core/models package I think. |
should we keep yaml and config structures together in configuration package ? |
merge develop into split-digger-config
merge develop into the branch
merge develop into the branch
Spartakovic
reviewed
Jun 13, 2023
Spartakovic
reviewed
Jun 13, 2023
merge develop into the branch
motatoes
approved these changes
Jun 15, 2023
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
split DiggerConfig into two parts, one for yaml parsing and one for config itself
breardon2011
pushed a commit
that referenced
this pull request
Sep 17, 2025
split DiggerConfig into two parts, one for yaml parsing and one for config itself
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.