Support org level rbac #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* merge develop into support org level rbac (#376)
Spartakovic
reviewed
Jun 16, 2023
merge develop into feat/support-org-level-rbac
Spartakovic
reviewed
Jun 20, 2023
Spartakovic
reviewed
Jun 20, 2023
Spartakovic
reviewed
Jun 20, 2023
| if err != nil { | ||
| log.Printf("Error publishing comment: %v", err) | ||
| } | ||
| log.Println(msg) |
There was a problem hiding this comment.
that message is actually useful :) it duplicates what we post as comment, but it make clear why job failed in logs
There was a problem hiding this comment.
ah alright, we probably need to sort out usages of log, fmt, and println at some point
Spartakovic
approved these changes
Jun 20, 2023
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
…rbac Support org level rbac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.