Skip to content

Priority order of policies #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Priority order of policies #404

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27008c5
* Fix priority order of policies. First we need to check if there is …
Spartakovic Jun 23, 2023
bbb7cfb
fix comment
Spartakovic Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions pkg/policy/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,23 +73,25 @@ func (p *DiggerHttpPolicyProvider) getPolicyForNamespace(namespace string, proje

}

// GetPolicy fetches policy for entire organisation, if not found for organisation then it will fetch it for project
// GetPolicy fetches policy for particular project, if not found then it will fallback to org level policy
func (p *DiggerHttpPolicyProvider) GetPolicy(organisation string, namespace string, projectName string) (string, error) {
content, resp, err := p.getPolicyForOrganisation(organisation)
content, resp, err := p.getPolicyForNamespace(namespace, projectName)
if err != nil {
return "", err
}
if resp.StatusCode == 200 {
return content, nil
} else if resp.StatusCode == 404 {
content, resp, err := p.getPolicyForNamespace(namespace, projectName)
content, resp, err := p.getPolicyForOrganisation(organisation)
if err != nil {
return "", err
}
if resp.StatusCode == 200 {
return content, nil
} else if resp.StatusCode == 404 {
return "", nil
} else {
return "", errors.New(fmt.Sprintf("unexpected response while fetching namespace policy: %v, code %v", content, resp.StatusCode))
return "", errors.New(fmt.Sprintf("unexpected response while fetching organisation policy: %v, code %v", content, resp.StatusCode))
}
} else {
return "", errors.New(fmt.Sprintf("unexpected response while fetching org policy: %v code %v", content, resp.StatusCode))
Expand All @@ -106,6 +108,11 @@ func (p DiggerPolicyChecker) Check(organisation string, namespace string, projec
if err != nil {
return false, err
}

if policy == "" {
return true, nil
}

ctx := context.Background()
fmt.Printf("DEBUG: passing the following input policy: %v ||| text: %v", input, policy)
query, err := rego.New(
Expand Down