Skip to content

Conversation

@motatoes
Copy link
Contributor

@motatoes motatoes commented Jun 29, 2023

  • support configurable digger organisation for digger rbac
  • improvements to allow for setting of organisation

@motatoes motatoes changed the title support configurable digger organisation for digger support configurable digger organisation for digger rbac Jun 29, 2023

type Checker interface {
Check(organisation string, namespace string, projectname string, command string, requestedBy string) (bool, error)
Check(githubOrganisation string, namespace string, projectname string, command string, requestedBy string) (bool, error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't rename it

) (bool, bool, error) {
appliesPerProject := make(map[string]bool)

organisation := strings.Split(projectNamespace, "/")[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is generic function called by other CI providers, so shouldn't rename it either

@motatoes motatoes merged commit bef3574 into develop Jul 5, 2023
ben-of-codecraft pushed a commit to ben-of-codecraft/digger that referenced this pull request May 21, 2024
* support configurable digger organisation for digger
breardon2011 pushed a commit that referenced this pull request Sep 17, 2025
* support configurable digger organisation for digger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants