-
Notifications
You must be signed in to change notification settings - Fork 562
support configurable digger organisation for digger rbac #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartakovic
reviewed
Jun 29, 2023
pkg/core/policy/policy.go
Outdated
|
|
||
| type Checker interface { | ||
| Check(organisation string, namespace string, projectname string, command string, requestedBy string) (bool, error) | ||
| Check(githubOrganisation string, namespace string, projectname string, command string, requestedBy string) (bool, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't rename it
Spartakovic
reviewed
Jun 29, 2023
| ) (bool, bool, error) { | ||
| appliesPerProject := make(map[string]bool) | ||
|
|
||
| organisation := strings.Split(projectNamespace, "/")[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is generic function called by other CI providers, so shouldn't rename it either
Spartakovic
approved these changes
Jul 5, 2023
ben-of-codecraft
pushed a commit
to ben-of-codecraft/digger
that referenced
this pull request
May 21, 2024
* support configurable digger organisation for digger
breardon2011
pushed a commit
that referenced
this pull request
Sep 17, 2025
* support configurable digger organisation for digger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.