Fix duplicate CORS headers on proxied responses#63
Merged
Conversation
The API server's CORS middleware adds Access-Control-Allow-Origin: *, and the worker's CORS middleware does the same. When the API proxies worker responses, it forwards all headers including CORS ones via Add(), resulting in duplicate "*, *" which browsers reject. Skip Access-Control-* headers when forwarding proxied responses — the outer server's own CORS middleware already handles these. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Preview Environment DestroyedThe preview environment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Access-Control-Allow-Origin: *Add(), resulting in duplicate*, *which browsers reject as invalid CORSAccess-Control-*headers when forwarding proxied responses — the outer server's own CORS middleware already handles theseTest plan
/api/sandboxes/{id}/filesno longer get duplicate CORS headers🤖 Generated with Claude Code