Merged
Conversation
We haven't actually tested the bare-make build of this in the app yet.
achou11
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't yet been using the bare-make builds of better-sqlite3 in comapeo-mobile, which is why I'm keeping the releases with the
-bare-makesuffix, to avoid messing with current builds. This will need a PR to comapeo-mobile to change downloadPrebuilds to add-bare-maketo theversionparameter, and the removal oftest_extension.nodewill not be needed any more.As well as adding the 16kb page size support, I've added a CI step to rename the
.nodefile, to match whatbetter-sqlite3expects when it tries to load it.I've tested this by running this workflow to build without releasing, then manually downloaded the build artifacts, added them to nodejs_assets, then ran the debug version of the app and tested creating an observation. I then opened the APK in the Android Studio APK analyzer and checked that it no longer shows an alignment warning for better_sqlite3.node.
Once we merge we should run the prebuild workflow for release
11.10.0, keeping the-bare-makesuffix. Then update comapeo-mobile to download this version.