feat: return audio attachments from the API#38
Merged
Conversation
gmaclennan
approved these changes
Dec 9, 2024
Member
gmaclennan
left a comment
gmaclennan
left a comment
There was a problem hiding this comment.
Looks good.
As a separate issue, these changes makes me think we are maybe making things difficult for ourselves by making variant optional in the attachments endpoint. I also wonder whether the observations endpoint should return all variant URLs, e.g. originalUrl, previewUrl, thumbnailUrl. When writing related frontend code it seems like this would be helpful for the non-cloud server work too.
This would be a breaking change that we can discuss and address separately to this PR.
Contributor
Author
|
Created #40 to discuss this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly addresses #25.