Skip to content

S-114025 update and merge workflow tasks#68

Merged
mkeretic1 merged 7 commits intorelease/24.3.xfrom
S-114025
Oct 16, 2024
Merged

S-114025 update and merge workflow tasks#68
mkeretic1 merged 7 commits intorelease/24.3.xfrom
S-114025

Conversation

@avidovic
Copy link
Copy Markdown
Contributor

@avidovic avidovic commented Oct 8, 2024

  • Summary: This pull request addresses joining two input tasks into one for live deployment configuration workflows

Version information

  • Tested against target systems and versions: FILL IN TARGET SYSTEMS AND TARGET SYSTEM VERSIONS HERE
  • Tested with Digital.AI Release version: FILL IN DIGITAL.AI RELEASE VERSION AND PLUGIN VERSIONS HERE

Review

  • If adding a new workflow, update the Releasefile.yaml for proper Digital.ai Release import.
  • Avoid using community plugins.
  • Do not use global or folder variables.
  • Confirm that variables follow the correct naming convention (camel case or snake case) and have appropriate labels and descriptions.
  • Workflows should have accurate titles and descriptions.
  • Verify that all phases and tasks have correct titles and descriptions.
  • Ensure the change fulfills and explains the business requirements properly.
  • Place the workflow in the correct folder based on its category, and ensure that proper documentation accompanies it.

QE

  • Confirm that the changes can be successfully imported into Digital.ai Release without any breaking issues.
  • Generate a workflow execution from the newly added or updated workflow and verify that there are no failures.
  • Check that all changed texts are unified through all workflows
  • Check descriptions for tasks, particularly for live deployment config
  • Check that all the configuration names are put in one task, not split (config name, app name/env name)

PR Merge Activity

  • Squash and merge the PR.
  • After the PR is merged, make sure to push the appropriate tags on the target branch to reflect the changes in customer installations.

@Hes-Siemelink
Copy link
Copy Markdown

Thank you, this is what I had in mind. Good job!
Just reading the texts from the diff here but they look clean and consistent.

@avidovic avidovic marked this pull request as ready for review October 16, 2024 14:21
@mkeretic1 mkeretic1 merged commit 508f4a6 into release/24.3.x Oct 16, 2024
@mkeretic1 mkeretic1 deleted the S-114025 branch October 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants