Skip to content

A fullish suite of tests.#188

Merged
sanason merged 2 commits intomasterfrom
automated-tests
Apr 22, 2026
Merged

A fullish suite of tests.#188
sanason merged 2 commits intomasterfrom
automated-tests

Conversation

@sanason
Copy link
Copy Markdown
Member

@sanason sanason commented Apr 10, 2026

This PR adds automated tests to replace the suite of tests that are run manually for each DAP code release (the manual testing has traditionally been performed by our Google Analytics partner). A spreadsheet documenting the the old manual test suite is here (only accessible to internal TTS people). I've added a column showing which automated test each of the old manual tests map to.

Several things that are missing from the automated tests as compared to the manual tests:

  1. I didn't completely finish covering everything in the spreadsheet.
  2. The spreadsheet is for DAP v8.2, which is almost 2 years old. Features have been added since then and need to be tested too. The spreadsheet came from our GA partners - we need to get a new copy from them.
  3. The spreadsheet suggests that manual testing is performed against Chrome, Firefox and Safari. The automated tests only test against Chrome.
  4. The manual tests involve three layers of testing (see below). The automated tests are primarily "code level" tests. See the testing README for a discussion of whether that level of testing is sufficient.
    • Code Level: Validating correct syntax insertion.
    • Hit Level: Monitoring the GIF requests that are sent to the Google Analytics servers by using a tool like Firebug on Firefox or the Google Analytics Debugger extension for Google Chrome.
    • Data Collection Level: Validating data in GA reports after data processing.

@sanason sanason marked this pull request as draft April 14, 2026 20:01
@sanason sanason marked this pull request as ready for review April 21, 2026 17:03
@sanason sanason force-pushed the automated-tests branch 2 times, most recently from 507ca70 to d9ee3eb Compare April 22, 2026 18:04
@sanason sanason merged commit bc285eb into master Apr 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant