feat: only run expectations if today matches scheduled day#553
Merged
tombrooks248 merged 2 commits intoMay 19, 2026
Merged
Conversation
19 tasks
tombrooks248
force-pushed
the
feat/only-run-expectations-if-today-matches-schedule
branch
from
dfa8ae7 to
3714ced
Compare
tombrooks248
deleted the
feat/only-run-expectations-if-today-matches-schedule
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Configure expectations rule generation so that it can skip a rule if that rule has a schedule set and today is not the day of the week set in the schedule.
Why
Tree and Tree Preservation Order when they run duplicate_geometry_check take a long time slowing down the pipelines this change will enable us to only run those checks on saturdays when it doesnt matter if the pipelines take a bit longer.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above. Please refer to the Digital Land Testing Guidance for more information.
have not been included
I have also run a full run through of ancient-woodland locally and it seems to run as expected.
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?