Provide content updates#1076
Conversation
WalkthroughThe changes unify and simplify submission instructions in two HTML templates by removing a feature flag conditional and presenting consistent guidance to users. Both templates now encourage users to check their data before submission and provide a standardised set of instructions and links for submitting information. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GetStartedPage
participant SubmissionForm
User->>GetStartedPage: Visit get-started.html
GetStartedPage-->>User: Show unified instructions and endpoint submission link
User->>SubmissionForm: Follow link to endpoint submission form
SubmissionForm-->>User: Provide submission interface
Estimated code review effort2 (10–30 minutes) Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File CoverageNo changed files found. |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/views/submit/lpa-details.html (1)
52-54: Consider an absolute path for the “check your data” linkThe href
check/upload-methodis relative to the current URL, which may break if this template is rendered from nested routes. Using an absolute path (e.g./check/upload-method) or an appropriate Nunjucks filter (as used elsewhere) makes the link robust.-Always <a href="check/upload-method" class="govuk-link">check your data before you provide it</a>. +Always <a href="/check/upload-method" class="govuk-link">check your data before you provide it</a>.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/views/organisations/get-started.html(1 hunks)src/views/submit/lpa-details.html(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
src/views/submit/lpa-details.html (1)
Learnt from: GeorgeGoodall-GovUk
PR: #593
File: src/content/statusPage.js:6-9
Timestamp: 2024-10-28T15:07:21.647Z
Learning: The message 'Do not close this page' in export const messageTexts within src/content/statusPage.js is a design decision and should remain unchanged.
src/views/organisations/get-started.html (1)
Learnt from: GeorgeGoodall-GovUk
PR: #593
File: src/content/statusPage.js:6-9
Timestamp: 2024-10-28T15:07:21.647Z
Learning: The message 'Do not close this page' in export const messageTexts within src/content/statusPage.js is a design decision and should remain unchanged.
🪛 GitHub Actions: Unit test coverage report
src/views/organisations/get-started.html
[error] 211-211: Template render error: unknown block tag: endif
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: run-tests / test
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Updated content around providing data to promote the Check tool prior to submitting.
What type of PR is this? (check all applicable)
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
Summary by CodeRabbit
New Features
Style