Remove view "dataset" link#733
Conversation
This was put in place as a stopgap when the service didn't have the capabilities to play back data to LPAs. This should now be removed, as it creates a disjointed journey for users. Usability testing sessions have evidenced the fact that people get lost when they click on the link.
WalkthroughThe changes in this pull request involve modifications to the HTML template for the dataset task list associated with an organisation and updates to the corresponding test suite. The HTML changes simplify the message displayed when there are no task list items by removing a hyperlink and retaining a core notification. The test suite updates reflect this change by removing assertions related to the now-absent link, while maintaining the overall structure and logic of the tests. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage Report
File CoverageNo changed files found. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/views/organisations/datasetTaskList.html (1)
60-60: LGTM! Consider enhancing the message clarity.The removal of the link aligns well with the PR objectives and should improve the user experience by preventing confusion. However, we could make the message slightly more informative.
Consider this minor enhancement to provide more context:
- <p class="govuk-body">There are no issues with {{ organisation.name }}'s {{ dataset.name }} dataset.</p> + <p class="govuk-body">There are no outstanding issues with {{ organisation.name }}'s {{ dataset.name }} dataset. No action is required.</p>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
src/views/organisations/datasetTaskList.html(1 hunks)test/unit/datasetTaskListPage.test.js(0 hunks)
💤 Files with no reviewable changes (1)
- test/unit/datasetTaskListPage.test.js
DilwoarH
deleted the
713-remove-url-to-consumer-site-from-task-list-page-empty-state
branch
3 participants
What type of PR is this? (check all applicable)
Description
This was put in place as a stopgap when the service didn't have the capabilities to play back data to LPAs.
This should now be removed, as it creates a disjointed journey for users. Usability testing sessions have evidenced the fact that people get lost when they click on the link.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Before
After
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
QA sign off
[optional] Are there any post-deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?
Summary by CodeRabbit
New Features
Bug Fixes