Skip to content

Conversation

@davidlehn
Copy link
Member

- Update dependencies.
- Update eslint config.
@codecov
Copy link

codecov bot commented Aug 9, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.37%. Comparing base (13c12a4) to head (d5f153c).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
lib/loggers/formatters.js 50.00% 2 Missing ⚠️
lib/index.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   81.35%   81.37%   +0.01%     
==========================================
  Files          10       10              
  Lines        1952     1954       +2     
==========================================
+ Hits         1588     1590       +2     
  Misses        364      364              
Files with missing lines Coverage Δ
lib/helpers.js 75.00% <100.00%> (ø)
lib/loggers/fileLogger.js 82.14% <100.00%> (ø)
lib/loggers/index.js 90.00% <100.00%> (ø)
lib/index.js 69.36% <75.00%> (+0.07%) ⬆️
lib/loggers/formatters.js 69.56% <50.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c12a4...d5f153c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@davidlehn davidlehn marked this pull request as ready for review September 2, 2025 23:14
@davidlehn davidlehn requested a review from dlongley September 2, 2025 23:14
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see CI is not green, assuming that will get sorted. Thanks!

Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
@davidlehn
Copy link
Member Author

I see CI is not green, assuming that will get sorted. Thanks!

The patch made style changes that touched lines that need coverage and the tooling is complaining. I think we'll ignore that in this PR.

@davidlehn
Copy link
Member Author

  • Merging.
  • Ignoring small coverage issue.
  • Only minor style issues so leaving a release for later.

@davidlehn davidlehn merged commit 262de27 into main Sep 22, 2025
7 of 8 checks passed
@davidlehn davidlehn deleted the use-eslint-v9 branch September 22, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants