ng build fails due to URLSearchParams is not defined at Object.<anonymous> (/usr/src/app/node_modules/node-forge/lib/log.js:305:5)

[sumitcodename47]

We are using Angular 6.3 for our UI development and suddenly today we can issues in our deployment on AWS using docker, below is the actual error.
We are using version "node-forge": "^0.10.0"

Step 18/29 : RUN ng build --prod  --output-hashing=none --build-optimizer false
306 | ---> Running in f7bada3f41a0
307 | URLSearchParams is not defined
308 | ReferenceError: URLSearchParams is not defined
309 | at Object.<anonymous> (/usr/src/app/node_modules/node-forge/lib/log.js:305:5)
310 | at Module._compile (module.js:643:30)
311 | at Object.Module._extensions..js (module.js:654:10)
312 | at Module.load (module.js:556:32)
313 | at tryModuleLoad (module.js:499:12)
314 | at Function.Module._load (module.js:491:3)
315 | at Module.require (module.js:587:17)
316 | at require (internal/module.js:11:18)
317 | at Object.<anonymous> (/usr/src/app/node_modules/node-forge/lib/index.js:17:1)
318 | at Module._compile (module.js:643:30)
319 | The command '/bin/sh -c ng build --prod  --output-hashing=none --build-optimizer false' returned a non-zero code: 1
320

Can someone tell why this is happening suddenly?

[LiangNex]

Same here.

[LiangNex]

We get this error on v1 version, which was released 6 days ago. Reverting it to 0.10.0 solves the problem.

[sumitcodename47]

yes.. I copied package-lock.json in our docker build that had 0.10.0 version and that resolved the issue.
@LiangNex you are right, the issue is with latest version.

[aljones15]

There is a note about this in the change log: https://github.com/digitalbazaar/forge/blob/main/CHANGELOG.md#100---2022-01-04

BREAKING: Remove forge.util.makeLink, forge.util.makeRequest, forge.util.parseFragment, forge.util.getQueryVariables. Replace with URL, URLSearchParams, and custom code as needed.

forge/lib/log.js

Lines 288 to 319 in 27286fe

	/*
	* Check for logging control query vars.
	*
	* console.level=<level-name>
	* Set's the console log level by name. Useful to override defaults and
	* allow more verbose logging before a user config is loaded.
	*
	* console.lock=<true|false>
	* Lock the console log level at whatever level it is set at. This is run
	* after console.level is processed. Useful to force a level of verbosity
	* that could otherwise be limited by a user config.
	*/
	if(sConsoleLogger !== null) {
	var query;
	if(typeof window !== 'undefined' && window.location) {
	query = new URL(window.location.href).searchParams;
	} else {
	query = new URLSearchParams();
	}
	if(query.has('console.level')) {
	// set with last value
	forge.log.setLevel(
	sConsoleLogger, query.get('console.level').slice(-1)[0]);
	}
	if(query.has('console.lock')) {
	// set with last value
	var lock = query.get('console.lock').slice(-1)[0];
	if(lock == 'true') {
	forge.log.lock(sConsoleLogger);
	}
	}
	}

URLSearchParams was added as a global in node v10:

https://nodejs.org/api/url.html#class-urlsearchparams

Which version of node are you building with?

Can I use it for URLSearchParams: https://caniuse.com/urlsearchparams

The engine setting for forge is here:

forge/package.json

Lines 62 to 64 in 1545316

	"engines": {
	"node": ">= 6.13.0"
	},

Which is set to the first version of node to contain URLSearchParams

I won't be taking any action on this, but it looks like you need node >= 10.

I tried using node: 6.17.1 and got the same error, but in node 10 it works just fine.

[davidlehn]

Yes, this is an issue in v1.0.0+. I'm surprised the node v6.x test runners are passing. This project is depending on those to fail when there are issues like this. [... looks into code ...] It seems the test suite had not been loading forge from the top-level for a decade+. Oops! Added that and the bugs appeared in older Node.js versions. Removed use of URLSearchParams since it was just there due to some other refactoring but is no longer needed.

Released as 1.2.1.

@sumitcodename47 @LiangNex: Were you getting failures just because your angular tools are running in an older than v10.0.0 Node.js? Out of curiosity, why are those tools not using newer Node.js versions?

[sumitcodename47]

@davidlehn yes, we are using Angular 6.3 and suddenly it was giving build error during docker deployment.